[Port dspace-7_x] Fix accessibility issues #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e229be4)
(cherry picked from commit 9ab3023)
- Added aria-label to the new submission buttons (for repositories with more than 1 entity type) - Fixed aria-controls pointing to non-existing ids (cherry picked from commit 8a7bdfe)
…ests for header (cherry picked from commit cc71d60)
- Added aria-labels to trash & select bitstream icon - Added aria-labels ui-switch components (had to upgrade ngx-ui-switch to 14.1.0) - Fixed aria-controls pointing to non-existing ids - Fixed bulk-access-browse not having the tab role on it's tabs - Fixed role="tablist" not having direct role="tab" by adding role="presentation" on the li elements - Fixed aria-expanded being set to true when collapsed and backwards for BulkAccessBrowseComponent & BulkAccessSettingsComponent (cherry picked from commit c300123)
- Fixed aria-controls on HealthComponentComponent, HealthInfoComponent, HealthInfoComponentComponent, HealthPanelComponent pointing to non-existing id - Fixed the tabs not having the role tab on its tabs - Fixed aria-expanded being set to true when collapsed and backwards for HealthPanelComponent & HealthInfoComponent - Fixed role="tablist" not having direct role="tab" by adding role="presentation" on the li elements - Fixed minor alignment issues (cherry picked from commit 3628c84)
- Added missing aria-label to buttons (cherry picked from commit 3bdfc38)
- Added missing aria-label to delete button (cherry picked from commit 4ea487c)
- Added missing aria-label to delete buttons - Moved hardcoded translation to translation files - Fix color contrast issues on buttons - Fix minor alignment issues - Added missing aria labels to input and select elements (cherry picked from commit 52c0977)
- Made Process Output keyboard accessible (cherry picked from commit 120835c)
- Added missing aria-labels to input checkboxes - Fixed minor css alignment (cherry picked from commit 57cc34c)
(cherry picked from commit 09bf8af)
- Added missing aria-labels to input checkboxes - Fixed role="tablist" not having direct role="tab" by adding role="presentation" on the li elements (cherry picked from commit 5b21d14)
- Added missing aria-labels to input checkboxes - Fixed multiple tab related accessibility issues (cherry picked from commit 1db83ba)
(cherry picked from commit 8ba17c9)
(cherry picked from commit 30fe424)
(cherry picked from commit 5566c99)
(cherry picked from commit 9a5ad0b)
…g for OrgUnits without organization.legalName field (cherry picked from commit e96d3cd)
(cherry picked from commit ff6dff7)
…f & replaced authentication dropdown menu link with button - Also fixed box-shadows not working the same way for all footer buttons/links (cherry picked from commit 4545b53)
tdonohue
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #2683 by @alexandrevryghem to
dspace-7_x.