Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable type-bind for checkbox inputs during submission #2693

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

hutattedonmyarm
Copy link
Contributor

@hutattedonmyarm hutattedonmyarm commented Dec 6, 2023

References

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

List of changes in this PR:

  • Added type-bind related properties to DynamicListRadioGroupModel and DynamicListModelConfig
  1. Verify that Submission form fields of item-type:list do not respect type-bind elements - they will always display when depositing a new item to DSpace 7.5 DSpace#8678 can be reproduced (radio buttons don't respect type-bind during submission #2687 is a duplicate of that), make sure that repeatable is set to false for the list item
  2. Apply this PR
  3. Restart the submission and verify, that the list input is only visible for the configured types

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: submission 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release and removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Dec 6, 2023
@qzhao-ulb
Copy link

qzhao-ulb commented Jan 16, 2024

We have the same problem, if a field is a list but unrepeatable, it will display with a radio in the submission. This radio but didn't work with type-bind together.

With this changes it works as well! I've tested on my local system with release 7.6.1 and would like to verify this solution.
Thanks a lot!

@tdonohue tdonohue requested a review from atarix83 February 15, 2024 15:57
@tdonohue tdonohue added this to the 8.0 milestone Apr 30, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @hutattedonmyarm ! I finally got to testing this today and your fix works!

@tdonohue tdonohue merged commit 81807da into DSpace:main Apr 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission
Projects
No open projects
Status: ✅ Done
4 participants