-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unauthorised community/collection logo fix #2689
base: main
Are you sure you want to change the base?
Conversation
My changes were trying to authorise the image the moment the component gets loaded, which caused anonymous users to always see the placeholder, even when they have access. I've fixed this to be more in-line with thumbnail component where it'll only try to authorise the image if the request for its content first fails. |
Hi @Atmire-Kristof, |
@Atmire-Kristof : This has code conflicts. If you wish to have it still considered for 8.0, please get this PR cleaned up and updated to latest |
I tried to test but I do not know how to make a collection or community logo to be restricted. |
@Atmire-Kristof |
References
Fixes #2688
Description
Fixes comcol-page-logo component to create a proper download link for the logo, attaching an authentication token to the url, akin to how thumbnail component handles bitstream urls.
This fixes proper view access to the community/collection logo on their pages.
Instructions for Reviewers
How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.