Added skip to main content button #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
the
port to dspace-7_x
tdonohue
added
the
1 APPROVAL
|
Hi @alexandrevryghem, |
|
@alexandrevryghem : If you could cleanup the conflicts tomorrow (Friday) or Monday, I'd love to test this for possible inclusion in 7.6.1. I believe the conflicts were accidentally caused by #2594 |
…content-button_contribute-main # Conflicts: # src/app/root/root.component.html
tdonohue
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Tested this today and it's working for both themes. Verified the invisible button exists (and works) using the WAVE Evaluation Tool extension for Chrome
|
Backport failed for Please cherry-pick the changes locally. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2607-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2607-to-dspace-7_x
git checkout -b backport-2607-to-dspace-7_x
ancref=$(git merge-base 684846ae36853aaf353b45e30fc300cfd14cfe41 19ed3c88e39ae3858845ec359eb4cf65bf7fa0ca)
git cherry-pick -x $ancref..19ed3c88e39ae3858845ec359eb4cf65bf7fa0ca |
|
Manually ported to |
tdonohue
removed
the
port to dspace-7_x
alexandrevryghem
deleted the
added-skip-to-main-content-button_contribute-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Created the skip to main content button to automatically skip the header, navigation, the user setting buttons, ...
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.