Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new access-status-list-element-badge css classes #2579

Merged
merged 5 commits into from
Nov 13, 2023
Merged

adding new access-status-list-element-badge css classes #2579

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e847e4e
adding new access-status-list-element-badge css classes
paulo-graca Oct 26, 2023
3bf2eb1
Create new access-status-badge.component.scss
paulo-graca Nov 10, 2023
6378dbe
new accessStatusClass atribute
paulo-graca Nov 10, 2023
c7eae92
remove replaceAll and use an object property
paulo-graca Nov 10, 2023
75b788d
adding ngOnDestroy for dealing with unsubscribe
paulo-graca Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ed/object-collection/shared/badges/access-status-badge/access-status-badge.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<ng-container *ngIf="showAccessStatus">
<span *ngIf="accessStatus$ | async as accessStatus">
<span class="badge badge-secondary">{{ accessStatus | translate }}</span>
<span [class]="'badge badge-secondary access-status-list-element-badge ' + accessStatus.replaceAll('.','-')">{{ accessStatus | translate }}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For performance reasons, it's not a good idea to put function calls in a template. Angular will re-render templates often, sometimes multiple times per second, so the exact same replace will happen many more times than necessary.

It's better to do the replace in the the map in the component ts file and map it to an object with a property for the label and the class (which is the label with the replacements). That way the replace only happens once

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @artlowel we weren't aware of this re-render issue. We will do as you suggest. Thank you for your feedback!

</span>
</ng-container>
Loading