Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port dspace-7_x] Minor header button improvements #2566

Merged
merged 4 commits into from
Oct 23, 2023
Merged

[Port dspace-7_x] Minor header button improvements #2566

merged 4 commits into from
Oct 23, 2023

Conversation

dspace-bot
Copy link
Contributor

Port of #2527 by @alexandrevryghem to dspace-7_x.

@alexandrevryghem @github-actions
Use gap instead of individual paddings for header icons
d6de6fe 
(cherry picked from commit 9f2a1d0)
@alexandrevryghem @github-actions
Themed LangSwitchComponent
d7f1d37 
(cherry picked from commit f9b4460)
@alexandrevryghem @github-actions
Applied same gap between header icons in the dspace theme and made th…
e82a1eb 
…e search field non-focusable when collapsed

(cherry picked from commit 58d31dd)
@alexandrevryghem @github-actions
Fixed invalid html structure the ExpandableNavbarSectionComponent had…
d7dba4b 
… an ul tag containing non-li tags

(cherry picked from commit fa56d5d)
@dspace-bot dspace-bot mentioned this pull request Oct 23, 2023
Merged
8 tasks
@tdonohue tdonohue added this to the 7.6.1 milestone Oct 23, 2023
@alanorth
Copy link
Contributor

Merging simple port of #2527, as it passes all tests and I have already tested it on 7.6 over there.

@alanorth alanorth merged commit a92aa05 into dspace-7_x Oct 23, 2023
8 checks passed
@alanorth alanorth deleted the backport-2527-to-dspace-7_x branch October 23, 2023 18:57
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 10, 2023
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
78aef51 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 10, 2023
@alanorth
src/themes/cgspace: fix gaps in header/navbar
f5f585a 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 15, 2023
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
c96464e 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 15, 2023
@alanorth
src/themes/cgspace: fix gaps in header/navbar
62bc62a 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 16, 2023
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
3495d98 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 16, 2023
@alanorth
src/themes/cgspace: fix gaps in header/navbar
d25ef00 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 23, 2023
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
4d45b4a 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 23, 2023
@alanorth
src/themes/cgspace: fix gaps in header/navbar
8f9b38c 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Jan 12, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
59880b9 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Jan 12, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
24c3d97 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Jan 23, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
12903db 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Jan 23, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
8acd952 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Jan 26, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
28d1d4a 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Jan 26, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
896608f 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 4, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
bc1f615 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 4, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
90c2885 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 6, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
3eb98a7 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 7, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
16d18b5 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 7, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
dc0658c 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 20, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
ac951dc 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 20, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
92cef4d 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 25, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
a4014d5 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 25, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
4b131ef 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 25, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
8c4fca6 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Feb 25, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
48cfb5a 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Mar 7, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
5d93706 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Mar 7, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
e862a37 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request May 27, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
b7fe8c7 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request May 27, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
336e3dc 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Aug 27, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
63d884a 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Aug 27, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
071ff8e 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Sep 30, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
de973b6 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Sep 30, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
36bb5e1 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Oct 9, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
318f437 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Oct 9, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
da5316e 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Oct 13, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
813b079 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Oct 13, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
4eaf94a 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 14, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
63ffca1 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 14, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
cb179ca 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 18, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
d09f5ba 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 18, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
2f64bc8 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 19, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
aa1bfa1 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 19, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
1b93697 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 22, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
4899212 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Nov 22, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
7df92c6 
Chase changes to header and navbar gaps.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Dec 20, 2024
@alanorth
src/themes/cgspace: fix for invalid HTML in navbar
6744602 
Chase changes to navbar.

See: DSpace#2566
alanorth added a commit to ilri/dspace-angular that referenced this pull request Dec 20, 2024
@alanorth
src/themes/cgspace: fix gaps in header/navbar
e9c2e05 
Chase changes to header and navbar gaps.

See: DSpace#2566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dspace-bot dspace-bot

Labels
accessibility low priority themes
Projects
DSpace 8.x and 7.6.x Maintenance
Archived in project
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dspace-bot @alanorth @tdonohue @alexandrevryghem