Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port main] Created separate ePerson pages for create/edit #2551

Merged
merged 6 commits into from
Oct 26, 2023
Merged

[Port main] Created separate ePerson pages for create/edit #2551

merged 6 commits into from
Oct 26, 2023

Conversation

alexandrevryghem
Copy link
Member

Port of #2391 to main

@alexandrevryghem
Created separate pages for edit & create EPersons
2a35180
@alexandrevryghem
Cleanup access-control components
9ac19d4 
- Use the same methods to retrieve the access-control urls
- Fix EPersonDataService.startEditingNewEPerson returning the incorrect link
@alexandrevryghem
Fix spacing issues for EPerson form buttons
998e1fa
@alexandrevryghem
Hide the delete EPerson/Group buttons when the user can't delete the …
75ec046 
…EPerson/Group
@alexandrevryghem
107664: Normalized ePerson & group edit url and moved error message t…
2e57176 
…o translation file
@alexandrevryghem
Merge remote-tracking branch 'upstream/main' into split-eperson-admin…
5151a26 
…istration-page_contribute-main

# Conflicts:
#	src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html
@alexandrevryghem alexandrevryghem mentioned this pull request Oct 19, 2023
Merged
8 tasks
@alexandrevryghem alexandrevryghem added bug usability authorization related to authorization, permissions or groups medium priority labels Oct 19, 2023
@alexandrevryghem alexandrevryghem added this to the 8.0 milestone Oct 19, 2023
tdonohue
tdonohue approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Verified this is a manual port of #2391 (which was already approved/tested). Code is identical. I restarted the tests though as they showed (seemingly random) failures. Once they succeed, I'll merge both PRs.

@tdonohue tdonohue merged commit 1d7147e into DSpace:main Oct 26, 2023
10 checks passed
@alexandrevryghem alexandrevryghem deleted the split-eperson-administration-page_contribute-main branch November 23, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

Assignees

@alexandrevryghem alexandrevryghem

Labels
authorization related to authorization, permissions or groups bug medium priority usability
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandrevryghem @tdonohue