Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browse by visual bug #2531

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

jensvannerum
Copy link
Contributor

References

Description

Simply clears the startsWith property if no URL parameter is given so that no text is present when we aren't actively searching on a query.

To test this PR just follow the steps from the issue and verify no text stays present ( I tested against demo.dspace.org)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Oct 2, 2023
@tdonohue tdonohue requested a review from hardyoyo October 5, 2023 14:49
@alanorth alanorth self-requested a review October 11, 2023 19:02
@alanorth
Copy link
Contributor

Thanks @jensvannerum! I tested the patch on DSpace 7.6 and it fixes the bug.

@alanorth alanorth merged commit 312b0aa into DSpace:main Oct 11, 2023
10 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue added this to the 8.0 milestone Oct 11, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Starting with "value" text stays on browse by pages, even when the query has been cleared.
4 participants