Fix display LogInComponent turning blank when entering wrong username/password combination

[alexandrevryghem]

References

• Fixes When you enter the wrong username/password combination, the login dropdown turns blank #2515
• Related Made it possible to reorder the login methods #2414

Description

Fixes bug where the LogInComponent turns blank when submitting invalid username/password combination.

Instructions for Reviewers

Instead of hiding the LogInContainerComponent by checking it's content, now it hides it by checking if the login method has a component with a rendersAuthMethodType decorator.

Guidance for how to test or review this PR:
You can test it locally but I wasn't able to reproduce the bug myself with my local setup

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[alanorth]

Reviewed by testing on DSpace 7.6.

I haven't managed to pinpoint the circumstances where it occurs, but I get a blank login menu very frequently when running in dev mode. With this patch I have not noticed the blank menu even once, and everything is working as normal as far as I can tell. I'm +1 by testing. Haven't reviewed the code yet.

[vins01-4science]

Hello @alexandrevryghem ,

thank you for this PR, I've tested its behavior and it seems to fix that issue.
I'm glad you fixed it, but I think that we can improve the code by not using the ElementRef and the d-none class. Instead we should filter out for all the AuthMethodType not configured by extending the filter

      map((methods: AuthMethod[]) => methods.filter((authMethod: AuthMethod) => authMethod.authMethodType !== AuthMethodType.Ip)),

inside the log-in.component.ts by using the new method inside the log-in.methods-decorator.ts.

I would like to ask for these changes, Do you agree with these requests?

Thank you.

[vins01-4science]

If the problem is that the component is undefined, it would be better to filter out all the authMethodType that are not configured. To achieve this behavior, you should filter them inside the log-in-component and add the related method inside the login-in.methods-decorator.
Do you agree @alexandrevryghem?

[alexandrevryghem]

Thnx for the review @vins01-4science, I indeed do agree that it would be even better to filter them out earlier so that it never even generates a LogInContainerComponent for AuthMethods without a Component. But I would prefer to just check if the Component is undefined though, so that it works dynamically, independently of which (future) AuthMethods are added.

[alexandrevryghem]

@vins01-4science, I implemented your feedback, and I also added a small commit to fix an error that I found while making the updates.
When you are running Angular, but your backend is down, the error ERROR TypeError: authorizations.filter is not a function is logged. This error occurs because AuthorizationDataService#isAuthorized returns false when an error is thrown, and oneAuthorizationMatchesFeature tries to iterate over it, which is obviously not possible. To fix this, an empty array needs to be returned, and this will still result in an observableOf(false) being returned by AuthorizationDataService#isAuthorized.

[vins01-4science]

Thank you @alexandrevryghem for the changes, everything seems to be correct to me 🚀 .
I am 👍 on this one.

[tdonohue]

👍 Thanks @alexandrevryghem ! Verified this fixes the bug & that reordering of login options (Shib, Password, etc) still works properly

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2530-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2530-to-dspace-7_x
git checkout -b backport-2530-to-dspace-7_x
ancref=$(git merge-base bf8519cc9484c144d58019c99ee65df58108dbb7 b8eaf90b03a3accd436356b85e8c7669f23eda0e)
git cherry-pick -x $ancref..b8eaf90b03a3accd436356b85e8c7669f23eda0e

[tdonohue]

Ported to 7.6.x manually via #2575