Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing or wrong Italian translations #2518

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

AndreaBarbasso
Copy link
Contributor

Description

I've checked the whole it.json5 file in order to find missing or wrong Italian translations, and then I fixed those errors.

Instructions for Reviewers

The changes have been made to the it.json5 file only, so it should not pose any issue as long as it is a valid json5 file.

List of changes in this PR:

  • Fixed missing or wrong Italian translations

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Sep 25, 2023
@alanorth alanorth self-requested a review September 26, 2023 07:20
@alanorth
Copy link
Contributor

Grazie @AndreaBarbasso! I tested these new strings on DSpace 7.6 and could verify that I see them in the UI. I will squash the two commits here into one so that we avoid having a commit for the linting fix in git history (no need to store it forever in git, better to fix it before committing!).

@alanorth alanorth merged commit f53c77b into DSpace:main Sep 26, 2023
10 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue added this to the 8.0 milestone Sep 26, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Sep 26, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Nov 13, 2024
Task/dspace cris 2023 02 x/DSC-2002

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants