Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port to dspace-7_x] Fix inherit policies at item move (Angular) #2458

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

KoenP
Copy link

@KoenP KoenP commented Aug 24, 2023

References

Description

Adds a tooltip to the "Inherit policies" checkbox on the "item move" page informing the user about the meaning of this option and warning them that the operation cannot be undone.

Instructions for Reviewers

Changes

  • In ItemMoveComponent template: Adds a tooltip to inheritPoliciesCheckbox.

Testing

  • Visit the item move page and hover over the "Inherit policies" checkbox to verify that the tooltip shows up.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@KoenP KoenP changed the base branch from main to dspace-7_x August 24, 2023 13:56
@KoenP KoenP force-pushed the backport-2423-to-dspace-7_x branch 2 times, most recently from 131f9d0 to 9b92965 Compare August 25, 2023 07:26
@KoenP KoenP force-pushed the backport-2423-to-dspace-7_x branch from 9b92965 to 815425c Compare August 25, 2023 08:18
@KoenP KoenP marked this pull request as ready for review September 4, 2023 12:37
@tdonohue tdonohue added bug authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge labels Sep 5, 2023
@tdonohue tdonohue changed the title Backport 2423 to dspace 7 x [Port to dspace-7_x] Fix inherit policies at item move (Angular) Sep 21, 2023
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is a manual port of #2423, which was tested already and approved. I've verified this is the same code.

@tdonohue tdonohue merged commit 3b6dd66 into DSpace:dspace-7_x Oct 25, 2023
@tdonohue tdonohue added this to the 7.6.1 milestone Oct 25, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Nov 29, 2024
[DSC-1988] Limit the number of items requested by  search manager

Approved-by: Giuseppe Digilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups bug
Projects
Development

Successfully merging this pull request may close these issues.

2 participants