Fix to Metadata Registry create new metadata schema doesn't appear without reload #1081

[hugo-escire]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Metadata Registry create new metadata schema doesn't appear without reload #1081

Description

On Metadata Registry page, when creating a new schema, the new schema is not listed after successful submit.
Name-field keeps old value.

Instructions for Reviewers

Create a new schema, but the doesn't show at least you edit, delete or reload the page.

List of changes in this PR:

• First, I made a refactor to avoid async issues onSubmit function of the metadata-schema-form.component.ts
• Second, I change the "clearMetadataSchemaRequests", because it has a little async issue in the old code. It was a cache problem, like @tdonohue mentioned.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[alanorth]

Thank you @hugo-escire. I tested the patch and confirmed it fixes the issue. I was able to see the new metadata schema in the registry immediately after saving, without refreshing.

So this looks good to me on functionality, but don't understand the TypeScript code so I will let someone else review and approve.

[alanorth]

@hugo-escire looking at this again, I notice that there are many changes to the code that are unrelated to the fix. This makes patches more "noisy" than they need to be, which means reviewing changes is more difficult and merging/rebasing is more likely to conflict due to unnecessary changes in the git history.

Would it be possible for you to rework this patch without the formatting changes? Thank you.

[hugo-escire]

Hi @alanorth, I reverted the format changes. Sorry for the delay.

[alanorth]

@hugo-escire no problem. Thanks for the fix. I will merge this now.

I personally try to avoid changes to the code that are not related to the fix, but I think we (the DSpace open source project) are partly to blame because we don't have Angular lint rules to catch these type of changes to whitespace or imports.

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix to Metadata Registry create new metadata schema doesn't appear without reload #1081 #2487