remove redundant cache default values from server.ts #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
performance / caching
tdonohue
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
👍 Thanks @saschaszott . Verified this looks good. These are defined by default in default-app-config.ts, which means this PR is "safe". It is not necessary to also have a fallback in server.ts.
tdonohue
added
port to dspace-7_x
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Nov 18, 2024
…#2412) [DSC-1957] Local installation of Nunito font Approved-by: Giuseppe Digilio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values of both
botCacheandanonymousCacheare defined indefault-app-config.ts.This PR removes redundant default values from
server.ts.