Made ConfirmationModalComponent more generic

[alexandrevryghem]

References

• Fixes Make ConfirmationModalComponent more generic #2264

Description

Currently the ConfirmationModalComponent uses the name from the DSpaceObjects to render the labels. The problem with this approach is that this modal only works for DSpace object and if you would want to use it for MetadataField (or any other child of ListableObject which isn't a child of DSpaceObject) it wouldn't work. Therefore it's better to only give the name to the modal instead of the whole DSpaceObject object.

Instructions for Reviewers

To make this component more generic I replaced the @Input() dso: DSpaceObject; with @Input() name: string and replaced all the usages

Guidance for how to test this PR:

• Open all the modals that have been changed and check that the names are still displayed correctly

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @alexandrevryghem ! Looks good and makes sense. I tested all the confirmation modals/popups that are modified and they all appear to work the same as before.