Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coar 3.0 resource types #1747

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

FelixNicol
Copy link
Contributor

@FelixNicol FelixNicol commented Aug 2, 2022

References

Description

Creating a Resource Type entity based on COAR Resource Types 3.0. New components and module to display the resource type details and search results. Metadata locale translation component and service. English and french i18n labels.

Instructions for Reviewers

List of changes in this PR:

  • There's 5 pulls in this pull request the first is the feature the other four are minor adjustments.
  • A new entity-group "resource-type" with page, item (grid and list), search (grid and list) elements.
  • A new module for this entity-group
  • A new field-component that display, if availlable, the metadata value corresponding to the user's locale.
  • New corresponding unit tests
  • Declaration of this new module in some other modules
  • MetadataUriValuesComponent and ItemPageUriFieldComponent declaration moved from item-page.module to shared.module.
  • New labels in french and english
  • Display the ResourceType on the Publication item page as a comment.

##Example of a resource type:
image

Include guidance for how to test or review your PR.
To test ResourceType, corresponding PR in DSpace/DSpace configurations should be running on the server.
Create a ResourceType collection with the entity type : ResourceType. You can then add new ResourceType items to the collection and link thoses resource types to publication entities.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • [n/a] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [n/a] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request introduces 4 alerts when merging 6037eb8 into bfbe389 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2022

This pull request introduces 4 alerts when merging 4bb19b0 into bfbe389 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Resource Type entity based on COAR Resource Types 3.0
2 participants