Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker.io prefix for images on Docker Hub #1687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use docker.io prefix for images on Docker Hub #1687

wants to merge 1 commit into from

Conversation

alanorth
Copy link
Contributor

References

Add references/links to any related issues or PRs. These may include:

Description

Docker assumes images are hosted on docker.io by default, but there are other container runtimes (for example Podman). It is better to use fully-qualified image names to support other runtime environments in the future.

Instructions for Reviewers

Try docker-compose -f docker-compose.yml build, up, down, etc for each Docker compose file.

List of changes in this PR:

  • First, change the prefix for all images to docker.io.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@alanorth alanorth requested a review from terrywbrady June 13, 2022 11:54
@tdonohue tdonohue added the backend: Docker related to DSpace deployment via Docker label Jun 13, 2022
@tdonohue
Copy link
Member

@alanorth : This appears to cause all e2e (integration tests) to fail, as it cannot pull down the docker image via GitHub actions. Error is:

no such image: docker.io/"dspace/dspace-cli:dspace-7_x": invalid reference format

@tdonohue tdonohue added the bug label Jun 13, 2022
@terrywbrady terrywbrady removed their request for review June 13, 2022 17:10
@kshepherd
Copy link
Member

Given that error and the changes, I think its the quotes breaking e2e rather than the name format itself..
I think we could try either quoting the full image name, or maybe we just accept and document that the DOCKER_OWNER and DSPACE_VER env vars should be sanitised since they might be used unquoted in the image reference

@alanorth alanorth force-pushed the docker.io-registry-prefix branch from 0848cf1 to 52f11ff Compare November 17, 2022 06:03
@alanorth
Copy link
Contributor Author

@kshepherd on second inspection let me change the quoting for that one. Perhaps it's something with the way Yaml interprets quoted values. I just updated the branch to main and force-pushed the branch with the new attempt.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Hi @alanorth,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@alanorth
Use docker.io prefix for images on Docker hub
eab286b 
Docker assumes docker.io by default, but there are other container
runtimes (for example Podman) where this should be explicit. It is
better to use fully-qualified image names to support other runtime
environments in the future.
@alanorth alanorth force-pushed the docker.io-registry-prefix branch from 52f11ff to eab286b Compare December 11, 2022 17:09
@github-actions
Copy link

Hi @alanorth,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend: Docker related to DSpace deployment via Docker bug merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use fully qualified image name for containers on Docker Hub
3 participants
@alanorth @tdonohue @kshepherd