Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accesibility issue in edit/access-control #2775

Closed
CrisGuzmanS opened this issue Jan 26, 2024 · 5 comments · Fixed by #2717
Closed

Accesibility issue in edit/access-control #2775

CrisGuzmanS opened this issue Jan 26, 2024 · 5 comments · Fixed by #2717
Assignees
Milestone

Comments

@CrisGuzmanS
Copy link
Contributor

Describe the bug
In the edit section for access control there are two accessibility errors regarding empty labels.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as an admin
  2. edit any access-control of a community
  3. Open WAVE Evaluation Tool

image

Expected behavior
There should be no error

@tdonohue i can take this activity

@CrisGuzmanS CrisGuzmanS added bug needs triage New issue needs triage and/or scheduling labels Jan 26, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Jan 26, 2024
@tdonohue
Copy link
Member

@CrisGuzmanS : Sounds good. I'll assign back to you then and move this to the 7.6.x board. Please submit a PR when you are ready and we'll get it applied to 8.0 and 7.6.x

@tdonohue tdonohue added accessibility and removed needs triage New issue needs triage and/or scheduling labels Jan 26, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Jan 26, 2024
@alexandrevryghem
Copy link
Member

alexandrevryghem commented Jan 26, 2024

@tdonohue & @CrisGuzmanS: This should already be fixed by PR #2717

@tdonohue
Copy link
Member

@alexandrevryghem : Thanks for catching that. It's very difficult to keep all these accessibility issues separate :)

@CrisGuzmanS: If you want to test out PR #2717 to see if it's already solved there, that would be appreciated. If it is solved, then there's no need for you to do any work. If it is NOT solved, then you can claim this as a separate task

(#2717 is also on my list to test, but I have a very long list right now)

@CrisGuzmanS
Copy link
Contributor Author

Hello @tdonohue & @alexandrevryghem , i have already verified that the issue has been solved in #2717
image

@tdonohue
Copy link
Member

Thanks @CrisGuzmanS for your help in testing that PR! In that case, I'm going to link this ticket up to #2717 and close the #2776 PR as a duplicate. Apologies again for the confusion.

(I'll try to move #2717 up my list too in order to avoid this happening again, as it seems to fix a lot of small accessibility issues)

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Jan 31, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment