Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoiding accesibility issues #2776

Closed
wants to merge 1 commit into from
Closed

Conversation

CrisGuzmanS
Copy link
Contributor

@CrisGuzmanS CrisGuzmanS commented Jan 26, 2024

References

Description

The accessibility error that appeared on the delete button for the edit access control section of a community has been removed.

Instructions for Reviewers

  1. Log in as admin
  2. Go to edit access control of any comunity
  3. Open WAVE Evaluation Tool
  4. You will see that there are not any error

image

List of changes in this PR:

  • i replaced the empty label to a div, to avoid accesibility error
  • i added 0.5rem in margin-bottom because label tag have that margin as default. (If I don't add it, the button moves up a little)
  • i added a tooltip in the button to describe it

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue
Copy link
Member

@CrisGuzmanS : Please see the recent comments on your ticket. It appears I overlooked that we may already have a PR to fix this issue (#2717).

My apologies, it's nearly impossible for me to remember what is in each PR. So, when claiming accessibility tickets, I'd recommend looking to see what other PRs may have the accessibility label to make sure it isn't already solved.

Overall, it sounds like this bug may be fixed already in #2717. If you want to check there, I'd appreciate it. If it is fixed there already, we should close this PR as a duplicate. If it is not fixed there, then we can leave it open.

@CrisGuzmanS
Copy link
Contributor Author

Ok @tdonohue I will verify that the issue is solved 👍

@tdonohue
Copy link
Member

Closing as @CrisGuzmanS verified this has already been solved in #2717. So, this is a duplicate of that PR.

@tdonohue tdonohue closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accesibility issue in edit/access-control
2 participants