Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort query param persists between switching search tabs on entity page, breaking search if not configured #2729

Open
MarieVerdonck opened this issue Jan 5, 2024 · 2 comments · May be fixed by #2734
Assignees
Labels
affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system

Comments

@MarieVerdonck
Copy link
Contributor

MarieVerdonck commented Jan 5, 2024

Describe the bug
For an entity page with a tabbed search using two different search configuration. If you in one of the tabs select a sort order which does not exist on the config of the other tab & then switch to the other tab, this will show error there because this sort option that is still present in url and thus applied, doesn't exist for this tab's discovery config.

To Reproduce
Steps to reproduce the behavior:

  1. Orgunit page with search for related Authors (Person) and related Search Projects: https://demo.dspace.org/entities/orgunit/04900cb5-0200-40cc-8df1-3d14a6f1b8ca
  2. Go To Search Projects tab => Select sort on title
  3. Switch to Authors tab => Will show error because sort on title (spc.sf=dc.title&spc.sd=ASC) doesn't exist for person discovery config.

Expected behavior
When switching between search tabs on entity page, the search params in url should be cleared.

@MarieVerdonck MarieVerdonck added bug needs triage New issue needs triage and/or scheduling labels Jan 5, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Jan 5, 2024
@MarieVerdonck
Copy link
Contributor Author

Atmire would like to claim this issue.

@tdonohue
Copy link
Member

tdonohue commented Jan 8, 2024

Thanks @MarieVerdonck . I'll assign it back to you then. Feel free to delegate to another person at Atmire as you see fit.

@tdonohue tdonohue removed this from DSpace Backlog Jan 8, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Jan 8, 2024
@tdonohue tdonohue added component: Discovery related to discovery search or browse system claimed: Atmire Atmire team is working on this issue & will contribute back and removed needs triage New issue needs triage and/or scheduling labels Jan 8, 2024
@tdonohue tdonohue added affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

2 participants