Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function in sidebar menu "Edit" => "Item" does not consider user rights #1331

Open
f-rapp opened this issue Sep 24, 2021 · 7 comments · May be fixed by DSpace/DSpace#8616 or #2011
Open

Search function in sidebar menu "Edit" => "Item" does not consider user rights #1331

f-rapp opened this issue Sep 24, 2021 · 7 comments · May be fixed by DSpace/DSpace#8616 or #2011
Assignees
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system component: Item (Archived) Item display or editing Estimate TBD high priority

Comments

@f-rapp
Copy link

f-rapp commented Sep 24, 2021

Describe the bug
DSpace 7
When a user clicks "Edit" => "Metadata" in the sidebar menu they get a list of items to search. However, the search function also lists items which the user is not allowed to edit.
When the user clicks on such an item he receives the following message:
grafik

To Reproduce
Steps to reproduce the behavior:

  1. Create a new user with no special rights.
  2. Log in with this user account.
  3. Click "Edit" => "Metadata" in the sidebar menu.
  4. Click on an item.

Expected behavior
The search function should only present items that the user is allowed to edit.

@tdonohue tdonohue transferred this issue from DSpace/DSpace Sep 24, 2021
@tdonohue tdonohue added bug component: Item (Archived) Item display or editing medium priority labels Sep 24, 2021
@tdonohue tdonohue added the help wanted Needs a volunteer to claim to move forward label Sep 24, 2021
@MarieVerdonck
Copy link
Contributor

@f-rapp: Think you mean 'Edit' => 'Item' or 'Import'/'Export' > 'Metadata' in the sidebar (since 'Edit' > 'Metadata' isn't an option there, only under Import/Export).
Noticed this problem as well.

When you log in as a submitter there is an 'Edit' => 'Item' option in the sidebar which opens the item edit selector, but all items present there are not editable by the submitter (results in 403 forbidden page)
The same problem exists for a community and collection admin (idem 'Edit' > 'Collection' shows collections this user can't edit thus resulting in 403 pages).

Additionally for the submitter the 'Import' > 'Metadata' option also results in a 403 forbidden page. And the 'Export' > 'Metadata' > Select any item > Results in a failure notification. (Idem for com/col admins, this shows com/col they can't export, and the import page also results in 403)

Also, logged in as supposed comm admin ([email protected]) the 'Edit' > 'Collection' option is shown (containing collections they can't edit), but not the 'Edit' > 'Community'.

@tdonohue
Copy link
Member

Related (loosely) to #1482

@tdonohue
Copy link
Member

Also related to this email thread: https://groups.google.com/g/dspace-tech/c/-SiQ_LGx_ks/m/pjWrdI4HBQAJ

@artlowel
Copy link
Member

We'd like to claim this ticket

@tdonohue tdonohue added claimed: Atmire Atmire team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward labels Oct 27, 2022
@tdonohue tdonohue moved this from To Do to In Progress in DSpace 7.5 release Oct 27, 2022
@ybnd
Copy link
Member

ybnd commented Jan 12, 2023

@tdonohue we've noticed the same problem occurs when creating or editing Communities/Collections

Since the fix would be almost identical to the one @KoenP wrote for edit+Item, we'd like to expand the scope of this issue and address everything within the existing PR

@tdonohue
Copy link
Member

@ybnd : It's ok with me to expand the scope here to include the Edit/Create Communities/Collection pages. Whether it should be in the same PR or a separate one may depend on how large the PR becomes (larger PRs obviously can be more difficult to review). That said, it's OK to move forward with additional fixes here.

@tdonohue tdonohue added this to the 7.5 milestone Jan 13, 2023
@ybnd
Copy link
Member

ybnd commented Jan 20, 2023

@tdonohue while expanding this behaviour to Communities & Collections we came to the conclusion that we should take some time to refactor how these sorts of "indexed authorizations" are handled in general.

This is too much for the scope of this PR; a more naive implementation would just lead to a lot of duplicated code now and double work later on.

It's probably best if we look at this in more detail for 7.6

@tdonohue tdonohue changed the title Search function in sidebar menu "Edit" => "Metadata" does not consider user rights Search function in sidebar menu "Edit" => "Item" does not consider user rights Jan 23, 2023
@tdonohue tdonohue modified the milestones: 7.5, 7.6 Feb 3, 2023
@tdonohue tdonohue moved this to 🏗 In Progress in DSpace 7.6 Release Feb 3, 2023
@tdonohue tdonohue added the component: Discovery related to discovery search or browse system label Mar 9, 2023
@tdonohue tdonohue removed this from the 7.6 milestone Jun 22, 2023
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 9.0 Release Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Discovery related to discovery search or browse system component: Item (Archived) Item display or editing Estimate TBD high priority
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

5 participants