fix: use the correct link name for find by href for findListByHref

DSpace · Aug 13, 2024 · d9d39b0 · d9d39b0
1 parent a862d84
commit d9d39b0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/app/core/data/base/base-data.service.ts b/src/app/core/data/base/base-data.service.ts
@@ -358,8 +358,9 @@ export class BaseDataService<T extends CacheableObject> implements HALDataServic
           for (const object of remoteDataObject.payload.page) {
             if (hasValue(object?._links)) {
               for (const followLinkName of Object.keys(object._links)) {
-                // only add the followLinks if they are embedded
-                if (hasValue(object[followLinkName]) && followLinkName !== 'self') {
+                // only add the followLinks if they are embedded, and we get only links from the linkMap with the correct name
+                const linkDefinition = getLinkDefinition((remoteDataObject.payload as any).constructor, followLinkName);
+                if (linkDefinition?.propertyName && hasValue(remoteDataObject.payload[linkDefinition.propertyName]) && followLinkName !== 'self') {
                   // followLink can be either an individual HALLink or a HALLink[]
                   const followLinksList: HALLink[] = [].concat(object._links[followLinkName]);
                   for (const individualFollowLink of followLinksList) {