Skip to content

Commit

Permalink
Merge branch 'split-eperson-administration-page_contribute-7.6' into …
Browse files Browse the repository at this point in the history
…split-eperson-administration-page_contribute-maintenance-7.6
  • Loading branch information
alexandrevryghem committed Oct 19, 2023
2 parents a419956 + 2e57176 commit d473fcd
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/app/access-control/access-control-routing-paths.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function getEPersonsRoute(): string {
}

export function getEPersonEditRoute(id: string): string {
return new URLCombiner(getEPersonsRoute(), id).toString();
return new URLCombiner(getEPersonsRoute(), id, 'edit').toString();
}

export const GROUP_PATH = 'groups';
Expand All @@ -18,5 +18,5 @@ export function getGroupsRoute() {
}

export function getGroupEditRoute(id: string) {
return new URLCombiner(getGroupsRoute(), id).toString();
return new URLCombiner(getGroupsRoute(), id, 'edit').toString();
}
4 changes: 2 additions & 2 deletions src/app/access-control/access-control-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import { EPersonResolver } from './epeople-registry/eperson-resolver.service';
canActivate: [SiteAdministratorGuard],
},
{
path: `${EPERSON_PATH}/:id`,
path: `${EPERSON_PATH}/:id/edit`,
component: EPersonFormComponent,
resolve: {
breadcrumb: I18nBreadcrumbResolver,
Expand Down Expand Up @@ -66,7 +66,7 @@ import { EPersonResolver } from './epeople-registry/eperson-resolver.service';
canActivate: [GroupAdministratorGuard]
},
{
path: `${GROUP_PATH}/:groupId`,
path: `${GROUP_PATH}/:groupId/edit`,
component: GroupFormComponent,
resolve: {
breadcrumb: I18nBreadcrumbResolver
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export class EPeopleRegistryComponent implements OnInit, OnDestroy {
if (restResponse.hasSucceeded) {
this.notificationsService.success(this.translateService.get(this.labelPrefix + 'notification.deleted.success', {name: this.dsoNameService.getName(ePerson)}));
} else {
this.notificationsService.error(`Error occurred when trying to delete EPerson with id: ${ePerson.id} with code: ${restResponse.statusCode} and message: ${restResponse.errorMessage}`);
this.notificationsService.error(this.translateService.get(this.labelPrefix + 'notification.deleted.success', { id: ePerson.id, statusCode: restResponse.statusCode, errorMessage: restResponse.errorMessage }));

Check warning on line 218 in src/app/access-control/epeople-registry/epeople-registry.component.ts

View check run for this annotation

Codecov / codecov/patch

src/app/access-control/epeople-registry/epeople-registry.component.ts#L218

Added line #L218 was not covered by tests
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion src/assets/i18n/en.json5
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@

"admin.access-control.epeople.form.goToGroups": "Add to groups",

"admin.access-control.epeople.notification.deleted.failure": "Failed to delete EPerson: \"{{name}}\"",
"admin.access-control.epeople.notification.deleted.failure": "Error occurred when trying to delete EPerson with id \"{{id}}\" with code: \"{{statusCode}}\" and message: \"{{restResponse.errorMessage}}\"",

"admin.access-control.epeople.notification.deleted.success": "Successfully deleted EPerson: \"{{name}}\"",

Expand Down

0 comments on commit d473fcd

Please sign in to comment.