Don't enforce ThemedComponent selectors in test HTML

DSpace · Mar 14, 2024 · 82b630a · 82b630a
1 parent d15327c
commit 82b630a
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 3 deletions.
diff --git a/lint/src/rules/html/themed-component-usages.ts b/lint/src/rules/html/themed-component-usages.ts
@@ -20,6 +20,10 @@ export default {
     }
   },
   create(context: any) {
+    if (context.getFilename().endsWith('.spec.ts')) {
+      return {};
+    }
+
     return {
       [`Element$1[name = /^${DISALLOWED_THEME_SELECTORS}/]`](node: any) {
         context.report({

diff --git a/lint/test/rules/themed-component-usages.spec.ts b/lint/test/rules/themed-component-usages.spec.ts
@@ -137,6 +137,36 @@ describe('themed-component-usages (HTML)', () => {
 <ds-test-themeable [test]="something"></ds-test-themeable>
         `,
       },
+      {
+        name: fixture('src/test.ts'),
+        code: `
+@Component({
+  template: '<ds-test-themeable></ds-test-themeable>'
+})
+class Test {
+}
+        `,
+      },
+      {
+        name: fixture('src/test.spec.ts'),
+        code: `
+@Component({
+  template: '<ds-test-themeable></ds-test-themeable>'
+})
+class Test {
+}
+        `,
+      },
+      {
+        filename: fixture('src/test.spec.ts'),
+        code: `
+@Component({
+  template: '<ds-base-test-themeable></ds-base-test-themeable>'
+})
+class Test {
+}
+        `,
+      },
     ],
     invalid: [
       {

diff --git a/src/app/my-dspace-page/collection-selector/collection-selector.component.spec.ts b/src/app/my-dspace-page/collection-selector/collection-selector.component.spec.ts
@@ -146,7 +146,7 @@ describe('CollectionSelectorComponent', () => {
     scheduler = getTestScheduler();
     fixture = TestBed.overrideComponent(CollectionSelectorComponent, {
       set: {
-        template: '<ds-collection-dropdown (selectionChange)="selectObject($event)"></ds-collection-dropdown>',
+        template: '<ds-base-collection-dropdown (selectionChange)="selectObject($event)"></ds-base-collection-dropdown>',
       },
     }).createComponent(CollectionSelectorComponent);
     component = fixture.componentInstance;

diff --git a/src/app/search-page/configuration-search-page.component.spec.ts b/src/app/search-page/configuration-search-page.component.spec.ts
@@ -20,10 +20,10 @@ const QUERY = 'test query';
 
 @Component({
   template: `
-    <ds-configuration-search-page [configuration]="'${CONFIGURATION}'"
+    <ds-base-configuration-search-page [configuration]="'${CONFIGURATION}'"
                                   [fixedFilterQuery]="'${QUERY}'"
                                   #configurationSearchPage>
-    </ds-configuration-search-page>
+    </ds-base-configuration-search-page>
   `,
 })
 class HostComponent {