Skip to content

Commit

Permalink
[CST-12825] Fixes ROR metadata display
Browse files Browse the repository at this point in the history
  • Loading branch information
vins01-4science committed Dec 15, 2023
1 parent e7f5c48 commit 56d3338
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@
>
</ds-themed-thumbnail>
</ds-metadata-field-wrapper>
<ds-generic-item-page-field
[fields]="['organization.identifier.ror']"
[img]="'./assets/images/ror-icon.svg'"
[item]="object"
[label]="'orgunit.page.ror'"
[urlRegex]="'(.*)ror\.org'"
>
</ds-generic-item-page-field>
<ds-generic-item-page-field [item]="object"
[fields]="['organization.foundingDate']"
[label]="'orgunit.page.dateestablished'">
Expand All @@ -40,6 +32,14 @@
</ds-generic-item-page-field>
</div>
<div class="col-xs-12 col-md-7">
<ds-generic-item-page-field
[fields]="['organization.identifier.ror']"
[img]="'./assets/images/ror-icon.svg'"
[item]="object"
[label]="'orgunit.page.ror'"
[urlRegex]="'(.*)ror\.org'"

Check failure

Code scanning / CodeQL

Useless regular-expression character escape High

The escape sequence '.' is equivalent to just '.', so the sequence may still represent a meta-character when it is used in a
regular expression
.
>
</ds-generic-item-page-field>
<ds-related-items
[parentItem]="object"
[relationType]="'isPublicationOfOrgUnit'"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
<!-- Render value as a link with icon -->
<ng-template #linkImg let-img="img" let-value="value">
<a [href]="value" class="dont-break-out ds-simple-metadata-link" target="_blank">
<img alt="metadata logo" height="24" src="{{img}}"/>{{value}}
<img alt="metadata logo" height="24" src="{{img}}"/>
{{value}}
</a>
</ng-template>

Expand Down

0 comments on commit 56d3338

Please sign in to comment.