Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with submission sections visibility #9783

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

atarix83
Copy link
Contributor

References

Description

See description here DSpace/dspace-angular#3276

Instructions for Reviewers

See instructions here DSpace/dspace-angular#3276

List of changes in this PR:

  • Exposed the missing attribute scope for the SubmissionSection object

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: submission Related to configurable submission system 1 APPROVAL pull request only requires a single approval to merge. port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 29, 2024
@tdonohue
Copy link
Member

@atarix83 : Just a quick note, this PR also seems to include a large number of unrelated commits (34 commits in total), when only the last few seem related to this bug fix. Could you try to rebase or cleanup this PR so that is shows the proper commits? It might be that you just need to rebase on latest main.

Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Dec 18, 2024
@tdonohue tdonohue added this to the 9.0 milestone Dec 18, 2024
@tdonohue tdonohue merged commit 13517d7 into DSpace:main Dec 18, 2024
22 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug component: submission Related to configurable submission system
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Submission step can't be hidden for only one submission scope
5 participants