Merge pull request #1728 from DSheirer/1619-javafx-windows-reappear-i…

…conified #1619 JavaFX Windows Restore to Previous Size/Location On View Request
DSheirer · Nov 11, 2023 · e79f2af · e79f2af
2 parents 672207c + ec7ee1c
commit e79f2af
Showing 1 changed file with 18 additions and 22 deletions.
diff --git a/src/main/java/io/github/dsheirer/gui/JavaFxWindowManager.java b/src/main/java/io/github/dsheirer/gui/JavaFxWindowManager.java
@@ -244,9 +244,7 @@ public void process(final JmbeEditorRequest request)
         else
         {
             execute(() -> {
-                getJmbeEditorStage().show();
-                getJmbeEditorStage().requestFocus();
-                getJmbeEditorStage().toFront();
+                restoreStage(getJmbeEditorStage());
                 getJmbeEditor().process(request);
             });
         }
@@ -317,9 +315,7 @@ public void process(PlaylistEditorRequest request)
         execute(() -> {
             try
             {
-                getPlaylistStage().show();
-                getPlaylistStage().requestFocus();
-                getPlaylistStage().toFront();
+                restoreStage(getPlaylistStage());
                 getPlaylistEditor().process(request);
             }
             catch(Throwable t)
@@ -367,9 +363,7 @@ private Stage getUserPreferencesStage()
     public void process(final ViewUserPreferenceEditorRequest request)
     {
         execute(() -> {
-            getUserPreferencesStage().show();
-            getUserPreferencesStage().requestFocus();
-            getUserPreferencesStage().toFront();
+            restoreStage(getUserPreferencesStage());
             getUserPreferencesEditor().process(request);
         });
     }
@@ -408,11 +402,7 @@ private Stage getChannelMapStage()
     @Subscribe
     public void process(final ViewIconManagerRequest request)
     {
-        execute(() -> {
-            getIconManagerStage().show();
-            getIconManagerStage().requestFocus();
-            getIconManagerStage().toFront();
-        });
+        execute(() -> restoreStage(getIconManagerStage()));
     }
 
     /**
@@ -422,9 +412,7 @@ public void process(final ViewIconManagerRequest request)
     public void process(final ViewChannelMapEditorRequest request)
     {
         execute(() -> {
-            getChannelMapStage().show();
-            getChannelMapStage().requestFocus();
-            getChannelMapStage().toFront();
+            restoreStage(getChannelMapStage());
             getChannelMapEditor().process(request);
         });
     }
@@ -435,11 +423,19 @@ public void process(final ViewChannelMapEditorRequest request)
     @Subscribe
     public void process(final ViewRecordingViewerRequest request)
     {
-        execute(() -> {
-            getRecordingViewerStage().show();
-            getRecordingViewerStage().requestFocus();
-            getRecordingViewerStage().toFront();
-        });
+        execute(() -> restoreStage(getRecordingViewerStage()));
+    }
+
+    /**
+     * Restores the stage to previous size and location.
+     * @param stage to restore.
+     */
+    private void restoreStage(Stage stage)
+    {
+        stage.setIconified(false);
+        stage.show();
+        stage.requestFocus();
+        stage.toFront();
     }
 
     @Override