Ignore unknown file types when loading a model #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering a file with an unknown file name extension, we used to simply crash the program. Instead, we now still try to load the model, but print a warning about potentially missing content. This enables limited use of capellambse on models that use external extension data, such as the `*.traceability` files created by the Publication for Capella extension. Note that even when simply loading such a model will succeed, some runtime data access may cause errors due to the missing extension data. To avoid creating bigger problems down the line, capellambse will refuse to save such a model without also passing the extra save() flag `i_have_a_recent_backup=True`, similar to the behavior when ignoring UUID duplication.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering a file with an unknown file name extension, we used to simply crash the program. Instead, we now still try to load the model, but print a warning about potentially missing content. This enables limited use of capellambse on models that use external extension data, such as the
*.traceabilityfiles created by the Publication for Capella extension.Note that even when simply loading such a model will succeed, some runtime data access may cause errors due to the missing extension data. To avoid creating bigger problems down the line, capellambse will refuse to save such a model without also passing the extra save() flag
i_have_a_recent_backup=True, similar to the behavior when ignoring UUID duplication.