Rework class / namespace discovery #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuestengecko
force-pushed
the
class-discovery
branch
3 times, most recently
from
ab8e8a6 to
12d008f
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
4 times, most recently
from
bf99b03 to
98e903d
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
3 times, most recently
from
7e13af6 to
e6a3963
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
from
e6a3963 to
1bb1abe
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
3 times, most recently
from
1ca4fa8 to
bb63451
Compare
This was referenced Nov 18, 2024
Wuestengecko
force-pushed
the
class-discovery
branch
from
bb63451 to
2b0b8c2
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
3 times, most recently
from
58ce90d to
c1cf3c0
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
6 times, most recently
from
c3f5125 to
43f0f85
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
from
43f0f85 to
ee2c6de
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
5 times, most recently
from
e701888 to
9394970
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
from
9394970 to
4cfea11
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
2 times, most recently
from
bcd22a4 to
deb8e14
Compare
Wuestengecko
force-pushed
the
class-discovery
branch
from
deb8e14 to
f4b51b0
Compare
This commit reworks the discovery of metamodel classes and namespaces. It introduces the `Namespace` object, whose instances keep track of the contained classes. Namespace objects are discovered through the Python entrypoint system. This makes extending the metamodel significantly easier. It's no longer necessary to add weirdly formatted entries into barely documented dictionaries, with errors only appearing at some arbitrary later point. Discovery of classes now happens via a custom metaclass by simply inheriting from `ModelElement`. This also allows additional metadata to be specified at subclassing time, which is especially relevant for namespace versioning. Due to this, the following decorators are now no longer needed and have been deprecated: - `@xtype_handler`: Was used to register classes for discovery, which is now done by the metaclass. - `@attr_equal`: This overwrites the `__eq__` method to compare against an attribute. Now handled by the `eq=...` class keyword argument.
Wuestengecko
force-pushed
the
class-discovery
branch
from
f4b51b0 to
2a340d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.