Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarative: Rename modify to set #394

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Mar 26, 2024

sync set should be called sync modify modify should be called set. it's weird that it has to be:

- parent: !uuid blahblah
  modify:
    description: "hey"

for parent, but for find it's:

- find:
    name: blah
  set:
    description: "hey"

even though they both do the same thing.

it should instead be:

- parent: !uuid blahblah
  set:
    description: "hey"

@Wuestengecko
Copy link
Member

it's weird that it has to be "modify" for parent, but for sync it has to be "set"

That's actually a good point, I didn't realize this during #387. But I do think that "set" makes more sense specifically in the sync context (because we might not have anything to modify yet), so we should rather rename "modify" to "set" instead (and keep "modify" as alias).

@huyenngn huyenngn force-pushed the refactor-sync-modify branch from bca7517 to bfde527 Compare March 26, 2024 16:34
@huyenngn huyenngn changed the title refactor(decl): Rename sync set to modify refactor(decl): Rename modify to set Mar 27, 2024
@Wuestengecko Wuestengecko force-pushed the refactor-sync-modify branch from bfde527 to 1bb6465 Compare March 27, 2024 12:23
@Wuestengecko Wuestengecko changed the title refactor(decl): Rename modify to set Declarative: Rename modify to set Mar 27, 2024
@Wuestengecko Wuestengecko merged commit b1de93b into master Mar 27, 2024
14 checks passed
@Wuestengecko Wuestengecko deleted the refactor-sync-modify branch March 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants