Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enforce pre-commit version >= 3.2.0 #384

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

MoritzWeber0
Copy link
Member

Older pre-commit versions are not compatible with the used pre-commit configuration since the commit stage was renamed to pre-commit.

This can lead to error messages like:

Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'

With a minimum required version the error messages is clearer.

Older pre-commit versions are not compatible with the used pre-commit
configuration since the `commit` stage was renamed to `pre-commit`.

This can lead to error messages like:
Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit,
post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'

With a minimum required version the error messages is clearer.
@MoritzWeber0 MoritzWeber0 force-pushed the minimum-pre-commit-version branch from 77181e9 to 9eb62cf Compare February 26, 2024 10:28
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Wuestengecko Wuestengecko merged commit e43a7d2 into master Feb 26, 2024
8 checks passed
@Wuestengecko Wuestengecko deleted the minimum-pre-commit-version branch February 26, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants