Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-decorations #372

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Fix-decorations #372

merged 4 commits into from
Jan 16, 2024

Conversation

ewuerger
Copy link
Member

Some fixes for decoration and styling of diagrams.

This fixes a bug where a deco-factory with a dependency to another
symbol (`StickFigureSymbol`) wouldn't add the dependency factory.
vik378
vik378 previously approved these changes Jan 16, 2024
Copy link
Member

@vik378 vik378 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -174,7 +174,6 @@ class in the form::
"_CAP_Activity_Orange": RGB(247, 218, 116),
"_CAP_Activity_Orange_min": RGB(255, 255, 197),
"_CAP_Actor_Blue": RGB(198, 230, 255),
"_CAP_Actor_Blue_label": RGB(0, 0, 0),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This map contains all the color names known to Capella, so that the style definitions below can use the exact names used in Capella's stylesheet.

This does mean that there are dups, but I guess it is what it is.

@Wuestengecko Wuestengecko merged commit 9ec6466 into master Jan 16, 2024
6 checks passed
@Wuestengecko Wuestengecko deleted the fix-decorations branch January 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants