Rename diagram_cache to diagram_image_cache #353
Conversation
| ( | ||
| "The 'jupyter_untrusted' argument is no longer needed and" | ||
| " will be removed soon. Please remove it from your calls." | ||
| ), | ||
| "The 'jupyter_untrusted' argument is no longer needed and" | ||
| " will be removed soon. Please remove it from your calls.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
Has nothing to do with the diagram_cache rename but still good catch. Mixing these things into one commit can be annoying in the future. Keep that in mind. Even though, I forget this from time to time,...
There was a problem hiding this comment.
What's the "good catch"? As far as I can see, the only thing that changed was some formatting (no parenthesis around the string anymore).
There was a problem hiding this comment.
I believe these formatting changes were made by running black --preview capellambse/model/__init__.py and not really by me, since I don't recall removing those parenthesis at all.
|
We determined that we won't be doing this after all. The name "diagram cache" has already been established too well, and is also used in other places and projects (like DSD-DBS/capella-collab-manager), changing it now would just cause unnecessary headache downstream. |
Closes #247
Added a deprecation warning for
diagram_cacheanddiagram_cache_subdirin the MelodyLoader and for theupdate_diagram_cachefunction.