Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash if there are no diagrams in the model #346

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Wuestengecko
Copy link
Member

Just because nobody bothered to draw pretty pictures, doesn't make the whole XML invalid. Apparently diagram-less models are a thing after all.

Just because nobody bothered to draw pretty pictures, doesn't make the
whole XML invalid. Apparently diagram-less models are a thing after all.
@Wuestengecko Wuestengecko requested a review from vik378 as a code owner October 17, 2023 14:51
@Wuestengecko Wuestengecko linked an issue Oct 17, 2023 that may be closed by this pull request
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple test for this? Just take the test model, delete all diagrams, save the model and then load it again. This should test that no ValueError is raised on a diagram-less model anymore.

Beside that and my concern about xpath2.
LGTM.

capellambse/aird/__init__.py Show resolved Hide resolved
@Wuestengecko Wuestengecko merged commit a3dfe6b into master Oct 25, 2023
6 checks passed
@Wuestengecko Wuestengecko deleted the no-diags-no-life branch October 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when enumerating diagrams on a model without diagrams
2 participants