Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-diagram-cache #342

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Fix-diagram-cache #342

merged 3 commits into from
Oct 9, 2023

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Oct 9, 2023

  • Expose the IndexEntry typed dictionary to the public.
  • Update the docstring to include descriptions for type and viewpoint attributes on IndexEntry.

@ewuerger ewuerger self-assigned this Oct 9, 2023
@ewuerger ewuerger added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 9, 2023
@dominik003 dominik003 mentioned this pull request Oct 9, 2023
Merged
@Wuestengecko
docs(model): Fix wrong description of "uuid" key in diagram cache index
17fd754 
This isn't actually a UUID (with the specific UUID format), but simply a
unique ID in the form of an opaque string.

In the interest of not breaking everything downstream, we'll keep the
key as "uuid" though.
@Wuestengecko Wuestengecko merged commit 20464ec into master Oct 9, 2023
5 checks passed
@Wuestengecko Wuestengecko deleted the fix-diagram-cache branch October 9, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wuestengecko Wuestengecko Awaiting requested review from Wuestengecko Wuestengecko is a code owner

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees

@ewuerger ewuerger

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @Wuestengecko