Don't use a stylesheet in SVGs #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dahbar
commented
Sep 27, 2023
•
dahbar
commented
- Remove SVG Stylesheet
- Add test coverage
dahbar
requested review from
ewuerger,
Wuestengecko and
vik378
as code owners
Wuestengecko
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Looks quite good already, only some minor issues.
After these, we'll also need to deprecate the jupyter_untrusted argument (i.e. emit a DeprecationWarning if it was passed in explicitly – both True and False values), and remove the related code. And then, of course, update the notebooks again. :)
This fixes most of the issues that came from using CSS in SVG files. Most notably, the notebook preview on Github can now properly render our SVG files, and we no longer have to resort to a crude hack to replace them with PNG images.
Wuestengecko
force-pushed
the
fix-remove-svgstylesheet
branch
from
e8ab3bf to
2a7db43
Compare
Wuestengecko
approved these changes
Oct 5, 2023
Wuestengecko
changed the title
Wuestengecko
added a commit
that referenced
this pull request
Feb 6, 2024
Since the merge of #341, this note no longer applies, because we don't use a stylesheet anymore. (PNG is still supported though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.