Add an optional metadata section to declarative modelling #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewuerger
force-pushed
the
decl-metadata
branch
2 times, most recently
from
cda702f to
ddeb5be
Compare
Wuestengecko
requested changes
Mar 3, 2023
ewuerger
force-pushed
the
decl-metadata
branch
2 times, most recently
from
0ebc532 to
4095e28
Compare
Wuestengecko
requested changes
Mar 13, 2023
ewuerger
force-pushed
the
decl-metadata
branch
3 times, most recently
from
7fb0773 to
294896b
Compare
Wuestengecko
force-pushed
the
decl-metadata
branch
3 times, most recently
from
dc55401 to
0ce78ee
Compare
These changes make `capellambse.decl` understand a new metadata section in the declarative modelling file. The `decl.apply` function gained a new `strict` argument. If set to True, metadata must be present in the provided YAML and match the passed model. Co-authored-by: Ernst Würger <[email protected]>
Wuestengecko
force-pushed
the
decl-metadata
branch
from
0ce78ee to
5a26637
Compare
Wuestengecko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarative modelling YAML needs a metadata section in order to ensure successful application of it that leads to a healthy model. With RM Bridge issue #39 and a following PR this will be implemented.
This PR anticipates these changes and implements metadata checks during
decl.apply()against themodel.info. These checks can be found here and are tested.