Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Better code #99

Merged
merged 3 commits into from
Jun 11, 2024
Merged

refactor: Better code #99

merged 3 commits into from
Jun 11, 2024

Conversation

huyenngn
Copy link
Member

No description provided.

@huyenngn huyenngn requested review from ewuerger and vik378 as code owners May 15, 2024 15:34
ewuerger
ewuerger approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not working yet.
:(

ewuerger
ewuerger requested changes May 16, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the tests please. Then I can approve it.

@huyenngn huyenngn force-pushed the refactor-default branch from 8feb126 to 9aa22f9 Compare May 21, 2024 07:54
@huyenngn huyenngn force-pushed the refactor-default branch from 9aa22f9 to ee52fd4 Compare May 21, 2024 08:19
@ewuerger ewuerger self-requested a review May 22, 2024 08:28
ewuerger
ewuerger requested changes May 22, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the function length. Then approved! You can merge then. :)
LGTM.

capellambse_context_diagrams/collectors/default.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/context.py Outdated Show resolved Hide resolved
@huyenngn huyenngn requested a review from Wuestengecko May 30, 2024 07:36
@Wuestengecko Wuestengecko mentioned this pull request Jun 3, 2024
Merged
ewuerger
ewuerger approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger self-assigned this Jun 11, 2024
@ewuerger ewuerger added the enhancement New feature or request label Jun 11, 2024
@ewuerger ewuerger merged commit 8ee1a41 into main Jun 11, 2024
10 checks passed
@ewuerger ewuerger deleted the refactor-default branch June 11, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wuestengecko Wuestengecko Wuestengecko left review comments

@ewuerger ewuerger ewuerger approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees

@ewuerger ewuerger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huyenngn @Wuestengecko @ewuerger