Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper to install elk.js ahead of time #97

Merged
merged 1 commit into from
May 13, 2024

Conversation

Wuestengecko
Copy link
Member

In one of our container builds, we want to explicitly preinstall the needed Node modules at build time. This significantly improves the render time of the first context diagram after container startup, as otherwise the modules would have to be installed during startup / first render.

This PR adds a small public helper function, which simply forwards to the private module that actually does the work.

Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This is well needed for other services as well!
LGTM.

@ewuerger ewuerger merged commit 79c0cf4 into main May 13, 2024
3 checks passed
@ewuerger ewuerger deleted the feat/add-a-helper-to-install-elkjs-ahead-of-time branch May 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants