Show nicer error if cachedir can't be created #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we cannot create the cache directory to install the elk.js dependencies, we used to crash with whatever error message the OS gave us. This can sometimes be misleading, e.g. when the message is talking about missing permissions, but in reality `$HOME` or `$XDG_CACHE_HOME` is simply set to a broken value. This commit catches an OSError here and instead shows a nicer error message (and also much more concise stack trace) with a concrete hint towards `$HOME`. This is mostly relevant when running inside a container or as a system service, as it's much easier to accidentally miss some envvars there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we cannot create the cache directory to install the elk.js dependencies, we used to crash with whatever error message the OS gave us. This can sometimes be misleading, e.g. when the message is talking about missing permissions, but in reality
$HOMEor$XDG_CACHE_HOMEis simply set to a broken value.This commit catches an OSError here and instead shows a nicer error message (and also much more concise stack trace) with a concrete hint towards
$HOME.This is mostly relevant when running inside a container or as a system service, as it's much easier to accidentally miss some envvars there.