fix(context): Restrict port collection by diagram type #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewuerger
force-pushed
the
remove-unstyled-ports
branch
from
b928d3e to
46bd596
Compare
|
From the commit description: This doesn't work, the right keyword is "Resolves". Note how in the issue it says "... added a commit that referenced this issue..." and not "that will close this issue". |
ewuerger
force-pushed
the
remove-unstyled-ports
branch
from
ef85787 to
88ec9c0
Compare
Before there was only a generic set of attribute names for ports, which lead to physical ports (PP) in the context. These are only in the stylesheet for certain diagrams (e.g. `PAB`). This commit restricts the used port attribute names from the diagram type. Resolves #50
This should never happen, but if `get_elkdata` is used directly it can happen. The default collector (connection with ports) is used.
Also switch to the pre-commit black mirror, which runs about 2x faster.
Also partitioning is now parametrized and can be controlled via render parameters.
- Rename attribute to just `tree_diagram` - Remove the `LAYOUT_OPTIONS` global dict - Add controlability of `edgeLabels.sideSelection`
ewuerger
force-pushed
the
remove-unstyled-ports
branch
from
88ec9c0 to
c9d1991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before there was only a generic set of attribute names for ports, which
lead to physical ports (PP) in the context. These are only in the
stylesheet for certain diagrams (e.g.
PAB). This commit restricts theused port attribute names from the diagram type.