Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map associations of subclasses to the actual class instead of root #160

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Map associations of subclasses to the actual class instead of root #160

merged 2 commits into from
Nov 13, 2024

Conversation

micha91
Copy link
Contributor

@micha91 micha91 commented Nov 13, 2024

No description provided.

ewuerger
ewuerger approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part isn't executed in the current test case with root. I tested it manually on one of the generalized classes.
LGTM.

@ewuerger ewuerger merged commit 0c6aa6f into main Nov 13, 2024
13 checks passed
@ewuerger ewuerger deleted the fix-associations-subclass branch November 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micha91 @ewuerger