Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat custom diagram #159

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Feat custom diagram #159

wants to merge 22 commits into from

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Nov 11, 2024 •
edited
Loading

@huyenngn huyenngn marked this pull request as ready for review November 11, 2024 12:27
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from 21b14b6 to ceb0bee Compare November 12, 2024 06:48
@huyenngn huyenngn marked this pull request as draft November 13, 2024 11:45
@huyenngn huyenngn marked this pull request as ready for review November 18, 2024 16:58
@huyenngn huyenngn force-pushed the feat-custom-diagram branch 3 times, most recently from 94adfba to 0df9376 Compare November 20, 2024 05:50
ewuerger
ewuerger requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astonishing work! You added a very promising new Diagram type which we could use for almost all other ContextDiagram collectors. You added documentation and a test case. Well done.

But there are some problems with the current implementation and the docs. These need to be fixed before I approve this PR. Also notice: There is currently a bug when only the owner box and the port is collected, the derived interface routine is triggered and overwrites the collected ELKInputData with a faulty one that renders the port as a child box inside of the owner box. Don't worry with #165 this is fixed by removing the routine. But good to know: We need to rebase this PR with the fix-derived-interfaces PR (or main including the PR - merge) first before merging it into main.

capellambse_context_diagrams/collectors/custom.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/collectors/custom.py Show resolved Hide resolved
capellambse_context_diagrams/collectors/custom.py Show resolved Hide resolved
capellambse_context_diagrams/collectors/custom.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/__init__.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/context.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/context.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/context.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/context.py Outdated Show resolved Hide resolved
docs/custom_diagram.md Outdated Show resolved Hide resolved
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from 0df9376 to 261ea06 Compare November 25, 2024 13:42
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from bed124b to 6305008 Compare November 25, 2024 14:57
@huyenngn huyenngn requested a review from ewuerger November 26, 2024 11:10
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from 9288e1b to e4dfd0d Compare November 26, 2024 12:46
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from 4d00c51 to 23b2ec0 Compare November 27, 2024 09:55
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from 23b2ec0 to c744a6b Compare November 27, 2024 10:01
ewuerger
ewuerger requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that is everything. But the mayor points for me, for now.

capellambse_context_diagrams/collectors/custom.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/collectors/custom.py Outdated Show resolved Hide resolved
Wuestengecko
Wuestengecko reviewed Dec 6, 2024
View reviewed changes
docs/custom_diagram.md Outdated Show resolved Hide resolved
capellambse_context_diagrams/collectors/custom.py Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Wuestengecko
Wuestengecko reviewed Dec 16, 2024
View reviewed changes
docs/custom_diagram.md Outdated Show resolved Hide resolved
docs/custom_diagram.md Outdated Show resolved Hide resolved
@Wuestengecko
Copy link
Member

Please also fix the CI, in case you haven't seen it yet.

@huyenngn huyenngn force-pushed the feat-custom-diagram branch from 4da9d43 to ce32494 Compare December 16, 2024 21:04
@huyenngn huyenngn force-pushed the feat-custom-diagram branch from ce32494 to 51772a8 Compare December 16, 2024 21:06
@huyenngn huyenngn requested review from Wuestengecko and removed request for Wuestengecko December 16, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wuestengecko Wuestengecko Wuestengecko left review comments

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

@ewuerger ewuerger Awaiting requested review from ewuerger ewuerger is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The minimum size calculation of boxes needs to be fixed
3 participants
@huyenngn @Wuestengecko @ewuerger