Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add unused ports flag and port label height calculation #158

Merged
merged 4 commits into from
Nov 5, 2024
Merged

feat: Add unused ports flag and port label height calculation #158

merged 4 commits into from
Nov 5, 2024

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Nov 5, 2024 •
edited
Loading

  • ´display_unused_ports´ to toggle unused ports
  • on ´display_port_labels´ box height is adjusted

TODO:

  • Tests for box height on display port labels
  • Tests for display unused ports

@huyenngn huyenngn changed the title feat: Add unused ports flag and simplify height calculation feat: Add unused ports flag and port label height calculation Nov 5, 2024
@huyenngn huyenngn marked this pull request as draft November 5, 2024 07:07
@huyenngn huyenngn force-pushed the feat-display-unused-ports branch 2 times, most recently from 48dd33a to a223058 Compare November 5, 2024 07:14
@huyenngn huyenngn marked this pull request as ready for review November 5, 2024 07:15
@huyenngn huyenngn force-pushed the feat-display-unused-ports branch from a223058 to 837944e Compare November 5, 2024 07:18
ewuerger
ewuerger requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tiny changes in the code, nothing regarding the logic. I tested it on PhysicalComponents. Looks good! After these I give the approval.

capellambse_context_diagrams/collectors/default.py Outdated Show resolved Hide resolved
capellambse_context_diagrams/context.py Outdated Show resolved Hide resolved
@huyenngn huyenngn force-pushed the feat-display-unused-ports branch from 6c92ac3 to 49e9c6e Compare November 5, 2024 10:28
@huyenngn @ewuerger
refactor: Group port flags
d68846f 
Co-authored-by: Ernst Würger <[email protected]>
@huyenngn huyenngn requested a review from ewuerger November 5, 2024 10:30
ewuerger
ewuerger approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit d261d66 into main Nov 5, 2024
13 checks passed
@ewuerger ewuerger deleted the feat-display-unused-ports branch November 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huyenngn @ewuerger