Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tree-view): Add handling of properties w/o Associations #140

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ewuerger
Copy link
Member

Simplified the association resolving significantly, thanks to the capellambse API. Extended the Class processing to now also handle the case when no Association was modelled even tho a separate Class was used for the Property.

@ewuerger ewuerger requested a review from vik378 as a code owner September 19, 2024 10:06
@ewuerger ewuerger self-assigned this Sep 19, 2024
@ewuerger ewuerger added bug Something isn't working enhancement New feature or request labels Sep 19, 2024
@ewuerger ewuerger merged commit 0fe7900 into main Sep 19, 2024
12 checks passed
@ewuerger ewuerger deleted the support-no-association-in-tree-view branch September 19, 2024 14:42
Comment on lines +67 to +68
self._edge_count.setdefault(cls.prop.uuid, 0)
self._edge_count[cls.prop.uuid] += 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beauty of a defaultdict is that you don't need the explicit setdefault call anymore. 🙃 But having it this way doesn't exactly hurt either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants