Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat-physical-link-context #138

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Feat-physical-link-context #138

merged 4 commits into from
Sep 18, 2024

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Sep 17, 2024 •
edited
Loading

Includes patching of port labels with OUTSIDE label position to get the labels closer to the port:

before patching:
image

after patching:
image

Still missing:

  • Add documentation for the PhysicalLink interface context diagram.

@ewuerger ewuerger requested a review from vik378 as a code owner September 17, 2024 16:07
@ewuerger ewuerger requested a review from huyenngn September 17, 2024 16:07
@ewuerger ewuerger self-assigned this Sep 17, 2024
Base automatically changed from capellambse-v0.6 to main September 18, 2024 10:00
@ewuerger ewuerger force-pushed the feat-physical-link-context branch from f8790bd to ccf91d7 Compare September 18, 2024 11:02
huyenngn
huyenngn approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@huyenngn huyenngn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 64d7be8 into main Sep 18, 2024
12 checks passed
@ewuerger ewuerger deleted the feat-physical-link-context branch September 18, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenngn huyenngn huyenngn approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees

@ewuerger ewuerger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @huyenngn