Feat port label #134
Merged
Feat port label #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyenngn
force-pushed
the
feat-port-label
branch
from
4daeaf4 to
3963911
Compare
ewuerger
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Just make the port label placement configurable from the render call and we can merge this. Good job!
Oh and I forgot this: Please add this to the documentation. We should show how port labels look like there. Normally we just reuse the test and add it to gen_images.py. So we need:
- Add a test
- Add documentation.
feat: Display port labels
huyenngn
force-pushed
the
feat-port-label
branch
from
9f72324 to
3e48e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels appear twice but that's an issue with the renderer in pycapellambse (fixed in DSD-DBS/py-capellambse#453)