Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply edge direction correction #132

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix: Apply edge direction correction #132

merged 3 commits into from
Aug 22, 2024

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Aug 19, 2024 •
edited
Loading

Closes #125

  • edges between target and the same element now all have the same direction
  • tree-view fix other kinds of associations
  • satisfy mypy

@huyenngn huyenngn force-pushed the fix-edge-direction branch from 2e6b4a9 to 475082e Compare August 19, 2024 20:56
ewuerger
ewuerger requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edge direction correction needs to be cumulative from the owner boxes (components).
The rest is confirmed and looks good!

@huyenngn huyenngn force-pushed the fix-edge-direction branch from b75461d to 1f508f0 Compare August 20, 2024 17:50
@huyenngn huyenngn force-pushed the fix-edge-direction branch from 1f508f0 to c13f8f7 Compare August 20, 2024 17:51
@huyenngn huyenngn requested a review from ewuerger August 21, 2024 10:06
ewuerger
ewuerger approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 7c1a30d into main Aug 22, 2024
12 checks passed
@ewuerger ewuerger deleted the fix-edge-direction branch August 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edge direction correction in context diagrams on boxes isn't done anymore
2 participants
@huyenngn @ewuerger