Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to capellambse v0.6.x #131

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Upgrade to capellambse v0.6.x #131

merged 4 commits into from
Sep 18, 2024

Conversation

Wuestengecko
Copy link
Member

This PR migrates the codebase to the new import structure and changed class names in capellambse v0.6.x.

The diff is a bit inflated, as I also took the opportunity to unify the imports, and also repair the mypy hook (so I could rely on it during the migration). The latter uncovered a variety of type errors, which I then also went ahead and fixed. I didn't touch any of the logic (as far as I could), so there shouldn't be any breakage.

I've marked the commit as breaking change, to try and make downstream more aware of this upgrade.

@ewuerger ewuerger self-assigned this Aug 12, 2024
@ewuerger ewuerger added the enhancement New feature or request label Aug 12, 2024
@Wuestengecko Wuestengecko force-pushed the capellambse-v0.6 branch 4 times, most recently from a6ea67e to 554970a Compare August 23, 2024 09:43
- The "description" field now uses the correct spelling of
  py-capellambse
- Shorten the license info in the PyPI sidebar to just the license name
ewuerger
ewuerger previously approved these changes Sep 18, 2024
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 23e2474 into main Sep 18, 2024
12 checks passed
@ewuerger ewuerger deleted the capellambse-v0.6 branch September 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants