Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change _elkjs typed dicts to pydantic elements #104

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Jun 5, 2024

Closes #73

@huyenngn huyenngn requested review from ewuerger and vik378 as code owners June 5, 2024 14:45
@huyenngn huyenngn marked this pull request as draft June 5, 2024 14:46
@huyenngn huyenngn force-pushed the refactor-pydantic-elkjs branch from 61cdead to fe69c87 Compare June 5, 2024 15:03
@ewuerger ewuerger self-assigned this Jun 11, 2024
@ewuerger ewuerger marked this pull request as ready for review June 11, 2024 09:48
@ewuerger ewuerger force-pushed the refactor-pydantic-elkjs branch from 279ad37 to a7cb6de Compare June 11, 2024 09:51
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 778e0b6 into main Jun 11, 2024
10 checks passed
@ewuerger ewuerger deleted the refactor-pydantic-elkjs branch June 11, 2024 10:07
huyenngn added a commit that referenced this pull request Jun 11, 2024
Input and output validation with pydantic.

---------

Co-authored-by: ewuerger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change _elkjs typed dicts to pydantic elements
2 participants