Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove obsolete link serializers #97

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Conversation

ewuerger
Copy link
Member

  • Removed obsolete handle_exchanges custom link serializers and therefore remove one parameter passed to the serializers
  • Mocked the generation of work items in the CLI test as this unnecessarily tests what is already covered in the unit tests

@ewuerger ewuerger self-assigned this Aug 20, 2024
@ewuerger ewuerger requested a review from micha91 August 20, 2024 08:44
@ewuerger ewuerger force-pushed the fix-links-and-cli-test branch from c05b588 to 318b959 Compare August 20, 2024 08:45
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

capella2polarion/converters/converter_config.py Outdated Show resolved Hide resolved
capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
tests/test_elements.py Outdated Show resolved Hide resolved
@ewuerger ewuerger force-pushed the fix-links-and-cli-test branch from 841c29d to c2fe9cc Compare August 20, 2024 14:26
@ewuerger ewuerger force-pushed the fix-links-and-cli-test branch from c2fe9cc to 654eca9 Compare August 20, 2024 14:46
@ewuerger ewuerger requested a review from micha91 August 20, 2024 14:47
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewuerger ewuerger changed the title Fix-links-and-cli-test fix: Remove obsolete link serializers Aug 21, 2024
@ewuerger ewuerger requested a review from micha91 August 21, 2024 08:18
@ewuerger ewuerger merged commit 42825f5 into main Aug 21, 2024
8 checks passed
@ewuerger ewuerger deleted the fix-links-and-cli-test branch August 21, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants